diff options
| author | Jean Delvare <jdelvare@suse.de> | 2015-04-20 11:21:13 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-06-06 08:19:39 -0700 |
| commit | dfa0af4392f58436b16b66a7fd12ba7a4a462ab2 (patch) | |
| tree | d9b108bb41986abb809f8b700adc82ea8ce6adb7 | |
| parent | ca486dd1cec6073c3ada3b32b928d38c54ac4b55 (diff) | |
| download | lwn-dfa0af4392f58436b16b66a7fd12ba7a4a462ab2.tar.gz lwn-dfa0af4392f58436b16b66a7fd12ba7a4a462ab2.zip | |
thermal: step_wise: Revert optimization
Commit 178c2490b99f898efc06d1ad75cadc84f13021a6 ("thermal: step_wise:
cdev only needs update on a new target state") broke driver acerhdf.
That driver abused the step_wise thermal governor until the bang_bang
governor was available, and the optimization broke this usage model.
Kernels v3.12 to v3.18 are affected. In v3.19 the acerhdf driver was
switched to the bang_bang governor and that solved the problem.
For kernels v3.12 to v3.17, the bang_bang governor isn't available
yet so the easiest fix is to revert the optimization.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Reported-by: Dieter Jurzitza (https://bugzilla.opensuse.org/show_bug.cgi?id=925961)
Tested-by: Peter Feuerer <peter@piie.net>
Tested-by: Dieter Jurzitza
| -rw-r--r-- | drivers/thermal/step_wise.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/thermal/step_wise.c b/drivers/thermal/step_wise.c index f251521baaa2..ee52ab7d3730 100644 --- a/drivers/thermal/step_wise.c +++ b/drivers/thermal/step_wise.c @@ -146,9 +146,6 @@ static void thermal_zone_trip_update(struct thermal_zone_device *tz, int trip) dev_dbg(&instance->cdev->device, "old_target=%d, target=%d\n", old_target, (int)instance->target); - if (old_target == instance->target) - continue; - /* Activate a passive thermal instance */ if (old_target == THERMAL_NO_TARGET && instance->target != THERMAL_NO_TARGET) |