diff options
| author | Ani Sinha <ani@arista.com> | 2014-09-08 14:49:59 -0700 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2015-11-14 18:00:03 +0100 |
| commit | dbbcea97ecdcee66c453ac4127cdf9bc6c8481a0 (patch) | |
| tree | b57db1341dc50030eb18a5f3123a6266f7fec506 | |
| parent | 5d7af5b07a42bf3292ca1d359c89b1fdd0ef534e (diff) | |
| download | lwn-dbbcea97ecdcee66c453ac4127cdf9bc6c8481a0.tar.gz lwn-dbbcea97ecdcee66c453ac4127cdf9bc6c8481a0.zip | |
net:socket: set msg_namelen to 0 if msg_name is passed as NULL in msghdr struct from userland.
commit 6a2a2b3ae0759843b22c929881cc184b00cc63ff upstream.
Linux manpage for recvmsg and sendmsg calls does not explicitly mention setting msg_namelen to 0 when
msg_name passed set as NULL. When developers don't set msg_namelen member in msghdr, it might contain garbage
value which will fail the validation check and sendmsg and recvmsg calls from kernel will return EINVAL. This will
break old binaries and any code for which there is no access to source code.
To fix this, we set msg_namelen to 0 when msg_name is passed as NULL from userland.
Signed-off-by: Ani Sinha <ani@arista.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
| -rw-r--r-- | net/socket.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/net/socket.c b/net/socket.c index 432b0bddd9e1..00634623573f 100644 --- a/net/socket.c +++ b/net/socket.c @@ -1970,6 +1970,9 @@ static int copy_msghdr_from_user(struct msghdr *kmsg, if (copy_from_user(kmsg, umsg, sizeof(struct msghdr))) return -EFAULT; + if (kmsg->msg_name == NULL) + kmsg->msg_namelen = 0; + if (kmsg->msg_namelen < 0) return -EINVAL; |