diff options
| author | Chuck Lever <chuck.lever@oracle.com> | 2024-10-17 11:03:52 -0400 |
|---|---|---|
| committer | Chuck Lever <chuck.lever@oracle.com> | 2024-11-18 20:23:01 -0500 |
| commit | da4f777e623936d4d93427b69fca37baefd62669 (patch) | |
| tree | fc1207929488f3ba2545ab42d54acb64e89af84e | |
| parent | d08bf5ea649c045175c191609ccd52644b85985f (diff) | |
| download | lwn-da4f777e623936d4d93427b69fca37baefd62669.tar.gz lwn-da4f777e623936d4d93427b69fca37baefd62669.zip | |
NFSD: Remove a never-true comparison
fh_size is an unsigned int, thus it can never be less than 0.
Fixes: d8b26071e65e ("NFSD: simplify struct nfsfh")
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
| -rw-r--r-- | fs/nfsd/nfsfh.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/nfsd/nfsfh.c b/fs/nfsd/nfsfh.c index 871de925a3df..6a831cb242df 100644 --- a/fs/nfsd/nfsfh.c +++ b/fs/nfsd/nfsfh.c @@ -766,7 +766,7 @@ char * SVCFH_fmt(struct svc_fh *fhp) struct knfsd_fh *fh = &fhp->fh_handle; static char buf[2+1+1+64*3+1]; - if (fh->fh_size < 0 || fh->fh_size> 64) + if (fh->fh_size > 64) return "bad-fh"; sprintf(buf, "%d: %*ph", fh->fh_size, fh->fh_size, fh->fh_raw); return buf; |