diff options
| author | Barry Song <song.bao.hua@hisilicon.com> | 2020-10-28 10:52:49 +1300 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2020-11-09 17:25:54 +0530 |
| commit | d9c8d4b278d167bf7cba83ec6fc15a0a17dfc407 (patch) | |
| tree | 949776533dcd3909b83e13156670eae2a0720b60 | |
| parent | 1ff206561920c9998058e52ea465347d4944b635 (diff) | |
| download | lwn-d9c8d4b278d167bf7cba83ec6fc15a0a17dfc407.tar.gz lwn-d9c8d4b278d167bf7cba83ec6fc15a0a17dfc407.zip | |
dmaengine: hisi_dma: remove redundant irqsave and irqrestore in hardIRQ
Running in hardIRQ, disabling IRQ is redundant since hardIRQ has disabled
IRQ. This patch removes the irqsave and irqstore to save some instruction
cycles.
Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
Acked-by: Zhou Wang <wangzhou1@hisilicon.com>
Link: https://lore.kernel.org/r/20201027215252.25820-8-song.bao.hua@hisilicon.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
| -rw-r--r-- | drivers/dma/hisi_dma.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/dma/hisi_dma.c b/drivers/dma/hisi_dma.c index e1a958ae7925..a259ee010e9b 100644 --- a/drivers/dma/hisi_dma.c +++ b/drivers/dma/hisi_dma.c @@ -431,9 +431,8 @@ static irqreturn_t hisi_dma_irq(int irq, void *data) struct hisi_dma_dev *hdma_dev = chan->hdma_dev; struct hisi_dma_desc *desc; struct hisi_dma_cqe *cqe; - unsigned long flags; - spin_lock_irqsave(&chan->vc.lock, flags); + spin_lock(&chan->vc.lock); desc = chan->desc; cqe = chan->cq + chan->cq_head; @@ -452,7 +451,7 @@ static irqreturn_t hisi_dma_irq(int irq, void *data) chan->desc = NULL; } - spin_unlock_irqrestore(&chan->vc.lock, flags); + spin_unlock(&chan->vc.lock); return IRQ_HANDLED; } |