diff options
| author | Mathias Krause <minipli@googlemail.com> | 2012-08-15 11:31:45 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-10-02 09:47:06 -0700 |
| commit | d5d3ca708a08caa3a55531b6b781edcb0f64724d (patch) | |
| tree | 3f2747a82f3c89c2b5af4d55aa58075bd7d7b891 | |
| parent | 9a897ce370b0bbe57961372c67bd0ffc2dd3f7ea (diff) | |
| download | lwn-d5d3ca708a08caa3a55531b6b781edcb0f64724d.tar.gz lwn-d5d3ca708a08caa3a55531b6b781edcb0f64724d.zip | |
atm: fix info leak via getsockname()
[ Upstream commit 3c0c5cfdcd4d69ffc4b9c0907cec99039f30a50a ]
The ATM code fails to initialize the two padding bytes of struct
sockaddr_atmpvc inserted for alignment. Add an explicit memset(0)
before filling the structure to avoid the info leak.
Signed-off-by: Mathias Krause <minipli@googlemail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | net/atm/pvc.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/atm/pvc.c b/net/atm/pvc.c index 437ee70c5e62..db0dd47de61b 100644 --- a/net/atm/pvc.c +++ b/net/atm/pvc.c @@ -94,6 +94,7 @@ static int pvc_getname(struct socket *sock, struct sockaddr *sockaddr, return -ENOTCONN; *sockaddr_len = sizeof(struct sockaddr_atmpvc); addr = (struct sockaddr_atmpvc *)sockaddr; + memset(addr, 0, sizeof(*addr)); addr->sap_family = AF_ATMPVC; addr->sap_addr.itf = vcc->dev->number; addr->sap_addr.vpi = vcc->vpi; |