diff options
| author | Peter Griffin <peter.griffin@linaro.org> | 2024-02-20 11:50:10 +0000 |
|---|---|---|
| committer | Lee Jones <lee@kernel.org> | 2024-02-23 16:02:02 +0000 |
| commit | d2b0680cf3b05490b579e71b0df6e07451977745 (patch) | |
| tree | 68d3314193b53470c6e76ec9dfacd0829f3e67ac | |
| parent | 3e038941c58753c88f2dcc2b1744806ac8727bb2 (diff) | |
| download | lwn-d2b0680cf3b05490b579e71b0df6e07451977745.tar.gz lwn-d2b0680cf3b05490b579e71b0df6e07451977745.zip | |
mfd: syscon: Call of_node_put() only when of_parse_phandle() takes a ref
of_parse_phandle() returns a device_node with refcount incremented, which
the callee needs to call of_node_put() on when done. We should only call
of_node_put() when the property argument is provided though as otherwise
nothing has taken a reference on the node.
Fixes: 45330bb43421 ("mfd: syscon: Allow property as NULL in syscon_regmap_lookup_by_phandle")
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
Link: https://lore.kernel.org/r/20240220115012.471689-2-peter.griffin@linaro.org
Signed-off-by: Lee Jones <lee@kernel.org>
| -rw-r--r-- | drivers/mfd/syscon.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c index c9550368d9ea..7d0e91164cba 100644 --- a/drivers/mfd/syscon.c +++ b/drivers/mfd/syscon.c @@ -238,7 +238,9 @@ struct regmap *syscon_regmap_lookup_by_phandle(struct device_node *np, return ERR_PTR(-ENODEV); regmap = syscon_node_to_regmap(syscon_np); - of_node_put(syscon_np); + + if (property) + of_node_put(syscon_np); return regmap; } |