summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrei Coardos <aboutphysycs@gmail.com>2023-07-25 15:36:23 +0300
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>2023-08-01 21:15:23 +0200
commitceac51b1ee43532d35d0182117b326306bcfe7f4 (patch)
tree3b310cccc2b2c4a586b2ae4a6ef726819107052d
parentc518e7dc64573e3e3a196e8b79caa4f77c612366 (diff)
downloadlwn-ceac51b1ee43532d35d0182117b326306bcfe7f4.tar.gz
lwn-ceac51b1ee43532d35d0182117b326306bcfe7f4.zip
gpio: max77620: remove unneeded platform_set_drvdata() call
This function call is not required because no counterpart platform_get_drvdata() call is present to leverage the private data of the driver. Since the private data is confined to this driver file, external access is not feasible. The use of this function appears redundant in the current context of the driver's implementation. Reviewed-by: Alexandru Ardelean <alex@shruggie.ro> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com> Reviewed-by: Andy Shevchenko <andy@kernel.org> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
-rw-r--r--drivers/gpio/gpio-max77620.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/gpio/gpio-max77620.c b/drivers/gpio/gpio-max77620.c
index c18b60e39a94..8c2a5609161f 100644
--- a/drivers/gpio/gpio-max77620.c
+++ b/drivers/gpio/gpio-max77620.c
@@ -331,8 +331,6 @@ static int max77620_gpio_probe(struct platform_device *pdev)
girq->init_hw = max77620_gpio_irq_init_hw;
girq->threaded = true;
- platform_set_drvdata(pdev, mgpio);
-
ret = devm_gpiochip_add_data(&pdev->dev, &mgpio->gpio_chip, mgpio);
if (ret < 0) {
dev_err(&pdev->dev, "gpio_init: Failed to add max77620_gpio\n");