diff options
| author | Zhen Lei <thunder.leizhen@huawei.com> | 2021-05-11 17:29:23 +0800 |
|---|---|---|
| committer | Maxime Ripard <maxime@cerno.tech> | 2021-05-11 16:34:15 +0200 |
| commit | ca0b0c1f4a2aa281bf68668e00400e2bfbdaff0e (patch) | |
| tree | 4ba876502f935ea104c78438e756735c4fa747a7 | |
| parent | fd531024bad7e5799e968ca70c0d3ca7b96b71ef (diff) | |
| download | lwn-ca0b0c1f4a2aa281bf68668e00400e2bfbdaff0e.tar.gz lwn-ca0b0c1f4a2aa281bf68668e00400e2bfbdaff0e.zip | |
drm/vc4: Remove redundant error printing in vc4_ioremap_regs()
When devm_ioremap_resource() fails, a clear enough error message will be
printed by its subfunction __devm_ioremap_resource(). The error
information contains the device name, failure cause, and possibly resource
information.
Therefore, remove the error printing here to simplify code and reduce the
binary size.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/20210511092923.4617-1-thunder.leizhen@huawei.com
| -rw-r--r-- | drivers/gpu/drm/vc4/vc4_drv.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c index 68ac0e7489a9..9eff45b48869 100644 --- a/drivers/gpu/drm/vc4/vc4_drv.c +++ b/drivers/gpu/drm/vc4/vc4_drv.c @@ -57,10 +57,8 @@ void __iomem *vc4_ioremap_regs(struct platform_device *dev, int index) res = platform_get_resource(dev, IORESOURCE_MEM, index); map = devm_ioremap_resource(&dev->dev, res); - if (IS_ERR(map)) { - DRM_ERROR("Failed to map registers: %ld\n", PTR_ERR(map)); + if (IS_ERR(map)) return map; - } return map; } |