diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2016-07-14 07:18:14 -0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@s-opensource.com> | 2016-11-18 14:22:27 -0200 |
| commit | c9205e18b41a6ef5ad73e1c4b86a78b2ea3ccb9b (patch) | |
| tree | 4d61c6df682fccd187176b8cc9abf7eac84fcc60 | |
| parent | 5911f629266d577c7697dd3e9797b2d1e947a40b (diff) | |
| download | lwn-c9205e18b41a6ef5ad73e1c4b86a78b2ea3ccb9b.tar.gz lwn-c9205e18b41a6ef5ad73e1c4b86a78b2ea3ccb9b.zip | |
[media] blackfin: check devm_pinctrl_get() for errors
devm_pinctrl_get() can fail so we should check for that.
Fixes: 0a6824bc10de ('[media] v4l2: blackfin: select proper pinctrl state in ppi_set_params if CONFIG_PINCTRL is enabled')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
| -rw-r--r-- | drivers/media/platform/blackfin/ppi.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/media/platform/blackfin/ppi.c b/drivers/media/platform/blackfin/ppi.c index cff63e511e6d..b8f3d9fa66e9 100644 --- a/drivers/media/platform/blackfin/ppi.c +++ b/drivers/media/platform/blackfin/ppi.c @@ -214,6 +214,8 @@ static int ppi_set_params(struct ppi_if *ppi, struct ppi_params *params) if (params->dlen > 24 || params->dlen <= 0) return -EINVAL; pctrl = devm_pinctrl_get(ppi->dev); + if (IS_ERR(pctrl)) + return PTR_ERR(pctrl); pstate = pinctrl_lookup_state(pctrl, pin_state[(params->dlen + 7) / 8 - 1]); if (pinctrl_select_state(pctrl, pstate)) |