summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrej Krutak <dev@andree.sk>2016-08-18 23:52:10 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2016-09-07 08:34:55 +0200
commitc869384f1168b67bc183af2a803a26a25dce4ff5 (patch)
treec5f84824874f40a42dcf59a75cf5f367284a8891
parent04790a5d92b5827082b8159e8a0202354c147a3d (diff)
downloadlwn-c869384f1168b67bc183af2a803a26a25dce4ff5.tar.gz
lwn-c869384f1168b67bc183af2a803a26a25dce4ff5.zip
ALSA: line6: Remove double line6_pcm_release() after failed acquire.
commit 7e4379eae0e31994ea645db1d13006ea8e5ce539 upstream. If there's an error, pcm is released in line6_pcm_acquire already. Fixes: 247d95ee6dd2 ('ALSA: line6: Handle error from line6_pcm_acquire()') Reviewed-by: Stefan Hajnoczi <stefanha@gmail.com> Signed-off-by: Andrej Krutak <dev@andree.sk> Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--sound/usb/line6/pcm.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/sound/usb/line6/pcm.c b/sound/usb/line6/pcm.c
index 204cc074adb9..2bc8879757f9 100644
--- a/sound/usb/line6/pcm.c
+++ b/sound/usb/line6/pcm.c
@@ -55,7 +55,6 @@ static int snd_line6_impulse_volume_put(struct snd_kcontrol *kcontrol,
err = line6_pcm_acquire(line6pcm, LINE6_STREAM_IMPULSE);
if (err < 0) {
line6pcm->impulse_volume = 0;
- line6_pcm_release(line6pcm, LINE6_STREAM_IMPULSE);
return err;
}
} else {