diff options
| author | Jean Delvare <jdelvare@suse.de> | 2022-06-21 15:28:40 +0200 |
|---|---|---|
| committer | Wim Van Sebroeck <wim@linux-watchdog.org> | 2022-07-23 14:21:23 +0200 |
| commit | c6d9c0798ed366a09a9e53d71edcd2266e34a6eb (patch) | |
| tree | 51dcc1e1406ccccdc8e40886b53173a0ce79a4fa | |
| parent | 418c951d637a2685392f52fd26113bfe14408f89 (diff) | |
| download | lwn-c6d9c0798ed366a09a9e53d71edcd2266e34a6eb.tar.gz lwn-c6d9c0798ed366a09a9e53d71edcd2266e34a6eb.zip | |
watchdog: sp5100_tco: Fix a memory leak of EFCH MMIO resource
Unlike release_mem_region(), a call to release_resource() does not
free the resource, so it has to be freed explicitly to avoid a memory
leak.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Fixes: 0578fff4aae5 ("Watchdog: sp5100_tco: Add initialization using EFCH MMIO")
Cc: Terry Bowman <terry.bowman@amd.com>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
Cc: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20220621152840.420a0f4c@endymion.delvare
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
| -rw-r--r-- | drivers/watchdog/sp5100_tco.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/watchdog/sp5100_tco.c b/drivers/watchdog/sp5100_tco.c index 86ffb58fbc85..ae54dd33e233 100644 --- a/drivers/watchdog/sp5100_tco.c +++ b/drivers/watchdog/sp5100_tco.c @@ -402,6 +402,7 @@ out: iounmap(addr); release_resource(res); + kfree(res); return ret; } |