diff options
| author | Markus Elfring <elfring@users.sourceforge.net> | 2015-02-05 16:07:43 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-03-18 16:56:40 +0100 |
| commit | c60b89aa3640ac4eb279213d93828a8100acb6b5 (patch) | |
| tree | 8a6d58e6dbd560d4bf89f79c345b7b10d49e73dc | |
| parent | 533726f736c2c32956d78ad6f49ffaada110cbfd (diff) | |
| download | lwn-c60b89aa3640ac4eb279213d93828a8100acb6b5.tar.gz lwn-c60b89aa3640ac4eb279213d93828a8100acb6b5.zip | |
USB: appledisplay: Deletion of a check before backlight_device_unregister()
The backlight_device_unregister() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/usb/misc/appledisplay.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/misc/appledisplay.c b/drivers/usb/misc/appledisplay.c index b3d245ef46ef..a0a3827b4aff 100644 --- a/drivers/usb/misc/appledisplay.c +++ b/drivers/usb/misc/appledisplay.c @@ -329,7 +329,7 @@ error: pdata->urbdata, pdata->urb->transfer_dma); usb_free_urb(pdata->urb); } - if (pdata->bd && !IS_ERR(pdata->bd)) + if (!IS_ERR(pdata->bd)) backlight_device_unregister(pdata->bd); kfree(pdata->msgdata); } |