diff options
| author | Andrzej Hajda <a.hajda@samsung.com> | 2015-09-21 15:34:00 +0200 |
|---|---|---|
| committer | Tomi Valkeinen <tomi.valkeinen@ti.com> | 2015-09-24 13:46:15 +0300 |
| commit | c50d5cd235210abffa1e88affbead1adbd5f294a (patch) | |
| tree | 6447c26b4de4cc3095d94c9ddaa3bd00ce6decd2 | |
| parent | 8a9d4626db312fe0a682c35ef43fe8d9160c2ecd (diff) | |
| download | lwn-c50d5cd235210abffa1e88affbead1adbd5f294a.tar.gz lwn-c50d5cd235210abffa1e88affbead1adbd5f294a.zip | |
video/omap: remove invalid check
regno is unsigned so it cannot be negative.
The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].
[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
| -rw-r--r-- | drivers/video/fbdev/omap/omapfb_main.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c index 1fb3ea3c98a1..393ae1bc07e8 100644 --- a/drivers/video/fbdev/omap/omapfb_main.c +++ b/drivers/video/fbdev/omap/omapfb_main.c @@ -276,11 +276,6 @@ static int _setcolreg(struct fb_info *info, u_int regno, u_int red, u_int green, if (r != 0) break; - if (regno < 0) { - r = -EINVAL; - break; - } - if (regno < 16) { u16 pal; pal = ((red >> (16 - var->red.length)) << |