diff options
| author | Kuniyuki Iwashima <kuniyu@amazon.com> | 2022-08-23 10:46:51 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-08-24 13:46:58 +0100 |
| commit | c42b7cddea47503411bfb5f2f93a4154aaffa2d9 (patch) | |
| tree | 92155026458b74f8e5ded8b63b4fa4df36cdee42 | |
| parent | d2154b0afa73c0159b2856f875c6b4fe7cf6a95e (diff) | |
| download | lwn-c42b7cddea47503411bfb5f2f93a4154aaffa2d9.tar.gz lwn-c42b7cddea47503411bfb5f2f93a4154aaffa2d9.zip | |
net: Fix a data-race around sysctl_net_busy_poll.
While reading sysctl_net_busy_poll, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its reader.
Fixes: 060212928670 ("net: add low latency socket poll")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | include/net/busy_poll.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/net/busy_poll.h b/include/net/busy_poll.h index c4898fcbf923..f90f0021f5f2 100644 --- a/include/net/busy_poll.h +++ b/include/net/busy_poll.h @@ -33,7 +33,7 @@ extern unsigned int sysctl_net_busy_poll __read_mostly; static inline bool net_busy_loop_on(void) { - return sysctl_net_busy_poll; + return READ_ONCE(sysctl_net_busy_poll); } static inline bool sk_can_busy_loop(const struct sock *sk) |