diff options
| author | Alexey Starikovskiy <astarikovskiy@suse.de> | 2008-11-03 14:26:40 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2009-02-06 14:00:43 -0800 |
| commit | c17b1f3e00077f32e6369f750c491c00e08e23f5 (patch) | |
| tree | 595b199e66d6d55e5778b958694318a36ac2993d | |
| parent | 9db287c1a187d68dab05c1823265baffa47c6297 (diff) | |
| download | lwn-c17b1f3e00077f32e6369f750c491c00e08e23f5.tar.gz lwn-c17b1f3e00077f32e6369f750c491c00e08e23f5.zip | |
ACPI EC: Fix regression due to use of uninitialized variable
commit d21cf3c16b1191f3154a51e0b20c82bf851cc553 upstream.
breakage introduced by following patch
commit 27663c5855b10af9ec67bc7dfba001426ba21222
Author: Matthew Wilcox <willy@linux.intel.com>
Date: Fri Oct 10 02:22:59 2008 -0400
acpi_evaluate_integer() does not clear passed variable if
there is an error at evaluation.
So if we ignore error, we must supply initialized variable.
http://bugzilla.kernel.org/show_bug.cgi?id=11917
Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>
Tested-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Signed-off-by: Len Brown <len.brown@intel.com>
Cc: Thomas Renninger <trenn@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | drivers/acpi/ec.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c index c20c94f59cc0..566206a256dc 100644 --- a/drivers/acpi/ec.c +++ b/drivers/acpi/ec.c @@ -769,7 +769,7 @@ static acpi_status ec_parse_device(acpi_handle handle, u32 Level, void *context, void **retval) { acpi_status status; - unsigned long long tmp; + unsigned long long tmp = 0; struct acpi_ec *ec = context; status = acpi_walk_resources(handle, METHOD_NAME__CRS, @@ -784,6 +784,7 @@ ec_parse_device(acpi_handle handle, u32 Level, void *context, void **retval) return status; ec->gpe = tmp; /* Use the global lock for all EC transactions? */ + tmp = 0; acpi_evaluate_integer(handle, "_GLK", NULL, &tmp); ec->global_lock = tmp; ec->handle = handle; |