summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNavid Emamdoost <navid.emamdoost@gmail.com>2019-10-04 14:34:54 -0500
committerHerbert Xu <herbert@gondor.apana.org.au>2019-10-10 23:42:45 +1100
commitc03b04dcdba1da39903e23cc4d072abf8f68f2dd (patch)
tree8740457dc1f8a16faee2065e01cea96d9b758ddd
parentffdde5932042600c6807d46c1550b28b0db6a3bc (diff)
downloadlwn-c03b04dcdba1da39903e23cc4d072abf8f68f2dd.tar.gz
lwn-c03b04dcdba1da39903e23cc4d072abf8f68f2dd.zip
crypto: user - fix memory leak in crypto_reportstat
In crypto_reportstat, a new skb is created by nlmsg_new(). This skb is leaked if crypto_reportstat_alg() fails. Required release for skb is added. Fixes: cac5818c25d0 ("crypto: user - Implement a generic crypto statistics") Cc: <stable@vger.kernel.org> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
-rw-r--r--crypto/crypto_user_stat.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/crypto/crypto_user_stat.c b/crypto/crypto_user_stat.c
index 8bad88413de1..1be95432fa23 100644
--- a/crypto/crypto_user_stat.c
+++ b/crypto/crypto_user_stat.c
@@ -328,8 +328,10 @@ int crypto_reportstat(struct sk_buff *in_skb, struct nlmsghdr *in_nlh,
drop_alg:
crypto_mod_put(alg);
- if (err)
+ if (err) {
+ kfree_skb(skb);
return err;
+ }
return nlmsg_unicast(net->crypto_nlsk, skb, NETLINK_CB(in_skb).portid);
}