diff options
| author | Jan Kara <jack@suse.cz> | 2014-10-30 10:53:16 -0400 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2014-11-13 19:02:37 +0100 |
| commit | bf4939e265bc444151d92fb838b43ca705c4ffbe (patch) | |
| tree | 9f77289dc292086dca806cb95abbc06a460f03ee | |
| parent | 82da3f09d4c518ffb596db2d1794d9e147da0a04 (diff) | |
| download | lwn-bf4939e265bc444151d92fb838b43ca705c4ffbe.tar.gz lwn-bf4939e265bc444151d92fb838b43ca705c4ffbe.zip | |
ext4: fix oops when loading block bitmap failed
commit 599a9b77ab289d85c2d5c8607624efbe1f552b0f upstream.
When we fail to load block bitmap in __ext4_new_inode() we will
dereference NULL pointer in ext4_journal_get_write_access(). So check
for error from ext4_read_block_bitmap().
Coverity-id: 989065
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
| -rw-r--r-- | fs/ext4/ialloc.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c index e0d23f72f771..fbc6df7b895d 100644 --- a/fs/ext4/ialloc.c +++ b/fs/ext4/ialloc.c @@ -864,6 +864,10 @@ got: struct buffer_head *block_bitmap_bh; block_bitmap_bh = ext4_read_block_bitmap(sb, group); + if (!block_bitmap_bh) { + err = -EIO; + goto out; + } BUFFER_TRACE(block_bitmap_bh, "get block bitmap access"); err = ext4_journal_get_write_access(handle, block_bitmap_bh); if (err) { |