diff options
| author | Yajun Deng <yajun.deng@linux.dev> | 2021-08-03 15:37:39 +0800 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2021-08-03 14:23:22 -0700 |
| commit | bebc3bbf5131b7f792b207e8fcac9a798bb23bbf (patch) | |
| tree | cbdff8a5bf2c94c55f7492ec77a42bfe95dba932 | |
| parent | c8f6c77d06fe6147d07cb0e4952db008f72767cb (diff) | |
| download | lwn-bebc3bbf5131b7f792b207e8fcac9a798bb23bbf.tar.gz lwn-bebc3bbf5131b7f792b207e8fcac9a798bb23bbf.zip | |
net: decnet: Fix refcount warning for new dn_fib_info
fib_treeref needs to be set after kzalloc. The old code had a ++ which
led to the confusion when the int was replaced by a refcount_t.
Fixes: 79976892f7ea ("net: convert fib_treeref from int to refcount_t")
Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
Reviewed-by: David Ahern <dsahern@kernel.org>
Link: https://lore.kernel.org/r/20210803073739.22339-1-yajun.deng@linux.dev
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rw-r--r-- | net/decnet/dn_fib.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/decnet/dn_fib.c b/net/decnet/dn_fib.c index 387a7e81dd00..153a5fc1bdde 100644 --- a/net/decnet/dn_fib.c +++ b/net/decnet/dn_fib.c @@ -389,7 +389,7 @@ link_it: return ofi; } - refcount_inc(&fi->fib_treeref); + refcount_set(&fi->fib_treeref, 1); refcount_set(&fi->fib_clntref, 1); spin_lock(&dn_fib_info_lock); fi->fib_next = dn_fib_info_list; |