diff options
| author | Sudip Mukherjee <sudipm.mukherjee@gmail.com> | 2015-09-27 17:13:55 -0700 |
|---|---|---|
| committer | Sasha Levin <sasha.levin@oracle.com> | 2015-12-02 23:25:47 -0500 |
| commit | bbdc0806b4a91db4bbb55c10be4889d7aa61e92b (patch) | |
| tree | 9f56e80534c649655efba6d89e958f14c9005b7c | |
| parent | da498f694c231f6560dc84fd5b8cb5169b7607aa (diff) | |
| download | lwn-bbdc0806b4a91db4bbb55c10be4889d7aa61e92b.tar.gz lwn-bbdc0806b4a91db4bbb55c10be4889d7aa61e92b.zip | |
Input: serio - fix blocking of parport
[ Upstream commit 1a5e251996e1b602f2ddc9261ee9de0ca1875bfa ]
If parkbd_allocate_serio() fails to allocate memory we are releasing the
parport but we missed unregistering the device. As a result this device
with exclusive access to that parport remains registered. And no other
device will be able to use that parport even though this driver has
failed to load.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
| -rw-r--r-- | drivers/input/serio/parkbd.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/input/serio/parkbd.c b/drivers/input/serio/parkbd.c index 26b45936f9fd..1e8cd6f1fe9e 100644 --- a/drivers/input/serio/parkbd.c +++ b/drivers/input/serio/parkbd.c @@ -194,6 +194,7 @@ static int __init parkbd_init(void) parkbd_port = parkbd_allocate_serio(); if (!parkbd_port) { parport_release(parkbd_dev); + parport_unregister_device(parkbd_dev); return -ENOMEM; } |