diff options
| author | Andrew Halaney <ahalaney@redhat.com> | 2024-02-28 14:12:06 -0600 |
|---|---|---|
| committer | Maxime Ripard <mripard@kernel.org> | 2024-03-05 12:13:57 +0100 |
| commit | b2ec429b69280001d85029dc50b5427af41eb641 (patch) | |
| tree | 346dbf51febe6a3e99e3be2352c01d4dec1562a2 | |
| parent | e635b7eb7062b464bbd9795308b1a80eac0b01f5 (diff) | |
| download | lwn-b2ec429b69280001d85029dc50b5427af41eb641.tar.gz lwn-b2ec429b69280001d85029dc50b5427af41eb641.zip | |
drm/tidss: Use dev_err_probe() over dev_dbg() when failing to probe the port
This gets logged out to /sys/kernel/debug/devices_deferred in the
-EPROBE_DEFER case and as an error otherwise. The message here provides
useful information to the user when troubleshooting why their display is
not working in either case, so let's make it output appropriately.
Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Tested-by: Enric Balletbo i Serra <eballetbo@kernel.org>
Link: https://lore.kernel.org/r/20240228-tidss-dev-err-probe-v1-1-5482252326d3@redhat.com
Signed-off-by: Maxime Ripard <mripard@kernel.org>
| -rw-r--r-- | drivers/gpu/drm/tidss/tidss_kms.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/gpu/drm/tidss/tidss_kms.c b/drivers/gpu/drm/tidss/tidss_kms.c index a0e494c806a9..f371518f8697 100644 --- a/drivers/gpu/drm/tidss/tidss_kms.c +++ b/drivers/gpu/drm/tidss/tidss_kms.c @@ -135,8 +135,7 @@ static int tidss_dispc_modeset_init(struct tidss_device *tidss) dev_dbg(dev, "no panel/bridge for port %d\n", i); continue; } else if (ret) { - dev_dbg(dev, "port %d probe returned %d\n", i, ret); - return ret; + return dev_err_probe(dev, ret, "port %d probe failed\n", i); } if (panel) { |