diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2016-07-15 14:09:13 +0300 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2016-09-23 09:29:21 +0200 |
| commit | addf8b9697f9efb97dd8f599fcf17a3e128cfd5f (patch) | |
| tree | 5b5d4ab4182c9bf9fb2009159634cbcda2af70c3 | |
| parent | 1bc74ff3eeb249ab98674bb31e92abee566bb3d5 (diff) | |
| download | lwn-addf8b9697f9efb97dd8f599fcf17a3e128cfd5f.tar.gz lwn-addf8b9697f9efb97dd8f599fcf17a3e128cfd5f.zip | |
crypto: nx - off by one bug in nx_of_update_msc()
commit e514cc0a492a3f39ef71b31590a7ef67537ee04b upstream.
The props->ap[] array is defined like this:
struct alg_props ap[NX_MAX_FC][NX_MAX_MODE][3];
So we can see that if msc->fc and msc->mode are == to NX_MAX_FC or
NX_MAX_MODE then we're off by one.
Fixes: ae0222b7289d ('powerpc/crypto: nx driver code supporting nx encryption')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
| -rw-r--r-- | drivers/crypto/nx/nx.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/crypto/nx/nx.c b/drivers/crypto/nx/nx.c index 5533fe31c90d..433a7696bf0f 100644 --- a/drivers/crypto/nx/nx.c +++ b/drivers/crypto/nx/nx.c @@ -330,7 +330,7 @@ static void nx_of_update_msc(struct device *dev, ((bytes_so_far + sizeof(struct msc_triplet)) <= lenp) && i < msc->triplets; i++) { - if (msc->fc > NX_MAX_FC || msc->mode > NX_MAX_MODE) { + if (msc->fc >= NX_MAX_FC || msc->mode >= NX_MAX_MODE) { dev_err(dev, "unknown function code/mode " "combo: %d/%d (ignored)\n", msc->fc, msc->mode); |