diff options
| author | Rafael J. Wysocki <rjw@sisk.pl> | 2008-12-29 19:19:07 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2009-02-06 13:47:24 -0800 |
| commit | a88af3b3c8938d43bb0b0a71508b546086789eee (patch) | |
| tree | 0afc50a30cbe0515eff72814c668a663344b36db | |
| parent | f74bb48f2e5ec381ba74f6952f55f0402c151d3e (diff) | |
| download | lwn-a88af3b3c8938d43bb0b0a71508b546086789eee.tar.gz lwn-a88af3b3c8938d43bb0b0a71508b546086789eee.zip | |
ACPI: Do not modify SCI_EN directly
commit 11e93130c7ce5228d484fd5e86f3984835d4256b upstream.
According to the ACPI specification the SCI_EN flag is controlled by
the hardware, which sets this flag to inform the kernel that ACPI is
enabled. For this reason, we shouldn't try to modify SCI_EN
directly. Also, we don't need to do it in irqrouter_resume(), since
lower-level resume code takes care of enabling ACPI in case it hasn't
been enabled by the BIOS before passing control to the kernel (which
by the way is against the ACPI specification).
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: Len Brown <len.brown@intel.com>
Cc: Thomas Renninger <trenn@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | drivers/acpi/pci_link.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c index e52ad91ce2dc..e33c0bc78fa8 100644 --- a/drivers/acpi/pci_link.c +++ b/drivers/acpi/pci_link.c @@ -796,10 +796,6 @@ static int irqrouter_resume(struct sys_device *dev) struct list_head *node = NULL; struct acpi_pci_link *link = NULL; - - /* Make sure SCI is enabled again (Apple firmware bug?) */ - acpi_set_register(ACPI_BITREG_SCI_ENABLE, 1); - list_for_each(node, &acpi_link.entries) { link = list_entry(node, struct acpi_pci_link, node); if (!link) { |