diff options
| author | Dawei Li <dawei.li@shingroup.cn> | 2024-04-16 16:54:53 +0800 |
|---|---|---|
| committer | Thomas Gleixner <tglx@linutronix.de> | 2024-04-24 21:23:49 +0200 |
| commit | a7fb69ffd7ce438a259b2f9fbcebc62f5caf2d4f (patch) | |
| tree | 7045c8c9c99a84577de6a2b43e21a0981a6471e0 | |
| parent | 5d650d1eba876717888a0951ed873ef0f1d8cf61 (diff) | |
| download | lwn-a7fb69ffd7ce438a259b2f9fbcebc62f5caf2d4f.tar.gz lwn-a7fb69ffd7ce438a259b2f9fbcebc62f5caf2d4f.zip | |
irqchip/sifive-plic: Avoid explicit cpumask allocation on stack
In general it's preferable to avoid placing cpumasks on the stack, as
for large values of NR_CPUS these can consume significant amounts of
stack space and make stack overflows more likely.
Use cpumask_first_and_and() to avoid the need for a temporary cpumask on
the stack.
Signed-off-by: Dawei Li <dawei.li@shingroup.cn>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Anup Patel <anup@brainfault.org>
Link: https://lore.kernel.org/r/20240416085454.3547175-7-dawei.li@shingroup.cn
| -rw-r--r-- | drivers/irqchip/irq-sifive-plic.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/drivers/irqchip/irq-sifive-plic.c b/drivers/irqchip/irq-sifive-plic.c index f3d4cb9e34f7..8fb183ced1e7 100644 --- a/drivers/irqchip/irq-sifive-plic.c +++ b/drivers/irqchip/irq-sifive-plic.c @@ -164,15 +164,12 @@ static int plic_set_affinity(struct irq_data *d, const struct cpumask *mask_val, bool force) { unsigned int cpu; - struct cpumask amask; struct plic_priv *priv = irq_data_get_irq_chip_data(d); - cpumask_and(&amask, &priv->lmask, mask_val); - if (force) - cpu = cpumask_first(&amask); + cpu = cpumask_first_and(&priv->lmask, mask_val); else - cpu = cpumask_any_and(&amask, cpu_online_mask); + cpu = cpumask_first_and_and(&priv->lmask, mask_val, cpu_online_mask); if (cpu >= nr_cpu_ids) return -EINVAL; |