diff options
| author | Paul Bolle <pebolle@tiscali.nl> | 2014-06-01 23:47:24 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-06-04 23:13:41 -0700 |
| commit | a79f5d2612ef7ecc8728e35e31d65da7a9ab49c7 (patch) | |
| tree | 20196bac8fe428383743783d57fe90a1af5c03d8 | |
| parent | ca05e3a7551b71891d42d637d3a1e443c6bbd781 (diff) | |
| download | lwn-a79f5d2612ef7ecc8728e35e31d65da7a9ab49c7.tar.gz lwn-a79f5d2612ef7ecc8728e35e31d65da7a9ab49c7.zip | |
isdn/capi: Make verbose reporting depend on capidrv
The Kconfig symbol ISDN_DRV_AVMB1_VERBOSE_REASON is only used for
capi_info2str(). That function is only used in capidrv.c. So setting it
without setting ISDN_CAPI_CAPIDRV is pointless. Make it depend on
ISDN_CAPI_CAPIDRV, rename it to ISDN_CAPI_CAPIDRV_VERBOSE and put its
entry after ISDN_CAPI_CAPIDRV's entry.
Since this symbol seems to be primarily used for debugging, keep it off
by default. By now the last users of capidrv hopefully know all they
need to know about the reasons for disconnecting.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Signed-off-by: Tilman Schmidt <tilman@imap.cc>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/isdn/capi/Kconfig | 16 | ||||
| -rw-r--r-- | drivers/isdn/capi/capidrv.c | 2 |
2 files changed, 9 insertions, 9 deletions
diff --git a/drivers/isdn/capi/Kconfig b/drivers/isdn/capi/Kconfig index 9816c51eb5c2..1d7adff265f7 100644 --- a/drivers/isdn/capi/Kconfig +++ b/drivers/isdn/capi/Kconfig @@ -1,11 +1,3 @@ -config ISDN_DRV_AVMB1_VERBOSE_REASON - bool "Verbose reason code reporting" - default y - help - If you say Y here, the CAPI drivers will give verbose reasons for - disconnecting. This will increase the size of the kernel by 7 KB. If - unsure, say Y. - config CAPI_TRACE bool "CAPI trace support" default y @@ -42,3 +34,11 @@ config ISDN_CAPI_CAPIDRV the legacy isdn4linux link layer. If you have a card which is supported by a CAPI driver, but still want to use old features like ippp interfaces or ttyI emulation, say Y/M here. + +config ISDN_CAPI_CAPIDRV_VERBOSE + bool "Verbose reason code reporting" + depends on ISDN_CAPI_CAPIDRV + help + If you say Y here, the capidrv interface will give verbose reasons + for disconnecting. This will increase the size of the kernel by 7 KB. + If unsure, say N. diff --git a/drivers/isdn/capi/capidrv.c b/drivers/isdn/capi/capidrv.c index 70e67f6a22ff..fd6d28f3fc36 100644 --- a/drivers/isdn/capi/capidrv.c +++ b/drivers/isdn/capi/capidrv.c @@ -765,7 +765,7 @@ static inline int new_bchan(capidrv_contr *card) /* ------------------------------------------------------------------- */ static char *capi_info2str(u16 reason) { -#ifndef CONFIG_ISDN_DRV_AVMB1_VERBOSE_REASON +#ifndef CONFIG_ISDN_CAPI_CAPIDRV_VERBOSE return ".."; #else switch (reason) { |