diff options
| author | Markus Elfring <elfring@users.sourceforge.net> | 2024-09-24 20:00:09 +0200 |
|---|---|---|
| committer | AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> | 2024-10-21 16:00:52 +0200 |
| commit | a1643ae9b3e3364edbb6cf285c5f2cf5d60336e6 (patch) | |
| tree | c13741cf6adb3b1b13020303f4efd8f90ecb3fab | |
| parent | d0fa55cc987026b8ce421b5a93239526641c44f1 (diff) | |
| download | lwn-a1643ae9b3e3364edbb6cf285c5f2cf5d60336e6.tar.gz lwn-a1643ae9b3e3364edbb6cf285c5f2cf5d60336e6.zip | |
soc: mediatek: mtk-svs: Call of_node_put(np) only once in svs_get_subsys_device()
An of_node_put(np) call was immediately used after a pointer check
for a of_find_device_by_node() call in this function implementation.
Thus call such a function only once instead directly before the check.
This issue was transformed by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/884f0a5d-e6d3-47dc-8a9e-201bb86b271f@web.de
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
| -rw-r--r-- | drivers/soc/mediatek/mtk-svs.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c index 9a91298c1253..7c349a94b45c 100644 --- a/drivers/soc/mediatek/mtk-svs.c +++ b/drivers/soc/mediatek/mtk-svs.c @@ -2133,14 +2133,12 @@ static struct device *svs_get_subsys_device(struct svs_platform *svsp, } pdev = of_find_device_by_node(np); + of_node_put(np); if (!pdev) { - of_node_put(np); dev_err(svsp->dev, "cannot find pdev by %s\n", node_name); return ERR_PTR(-ENXIO); } - of_node_put(np); - return &pdev->dev; } |