diff options
| author | Pablo Neira Ayuso <pablo@netfilter.org> | 2015-01-04 15:20:41 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-01-29 17:40:46 -0800 |
| commit | 9eed1585b50df5c909579c43637bda2d088019ee (patch) | |
| tree | f42bf44c2431f642b76447c91e196c7eba02dbd5 | |
| parent | 436322eeda54e4c8ebb09c7a293dc169afeabb7a (diff) | |
| download | lwn-9eed1585b50df5c909579c43637bda2d088019ee.tar.gz lwn-9eed1585b50df5c909579c43637bda2d088019ee.zip | |
netfilter: nfnetlink: relax strict multicast group check from netlink_bind
commit 62924af247e95de7041a6d6f2d06cdd05152e2dc upstream.
Relax the checking that was introduced in 97840cb ("netfilter:
nfnetlink: fix insufficient validation in nfnetlink_bind") when the
subscription bitmask is used. Existing userspace code code may request
to listen to all of the existing netlink groups by setting an all to one
subscription group bitmask. Netlink already validates subscription via
setsockopt() for us.
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | net/netfilter/nfnetlink.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/netfilter/nfnetlink.c b/net/netfilter/nfnetlink.c index c6619d4bcc32..1aa7049c93f5 100644 --- a/net/netfilter/nfnetlink.c +++ b/net/netfilter/nfnetlink.c @@ -470,7 +470,7 @@ static int nfnetlink_bind(int group) int type; if (group <= NFNLGRP_NONE || group > NFNLGRP_MAX) - return -EINVAL; + return 0; type = nfnl_group2type[group]; |