diff options
| author | Rusty Russell <rusty@rustcorp.com.au> | 2014-05-14 10:54:19 +0930 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2015-04-09 14:13:44 +0200 |
| commit | 9dde9641037a74e968b79685ddaf2ed1311152e8 (patch) | |
| tree | fc01b1224e7da5bad6f4004765a4ac3503d7b8f3 | |
| parent | f80c5f13970259005e64365c80c8d8f00d787c79 (diff) | |
| download | lwn-9dde9641037a74e968b79685ddaf2ed1311152e8.tar.gz lwn-9dde9641037a74e968b79685ddaf2ed1311152e8.zip | |
module: set nx before marking module MODULE_STATE_COMING.
commit 4982223e51e8ea9d09bb33c8323b5ec1877b2b51 upstream.
We currently set RO & NX on modules very late: after we move them from
MODULE_STATE_UNFORMED to MODULE_STATE_COMING, and after we call
parse_args() (which can exec code in the module).
Much better is to do it in complete_formation() and then call
the notifier.
This means that the notifiers will be called on a module which
is already RO & NX, so that may cause problems (ftrace already
changed so they're unaffected).
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
| -rw-r--r-- | kernel/module.c | 32 |
1 files changed, 17 insertions, 15 deletions
diff --git a/kernel/module.c b/kernel/module.c index f3c612e45330..3edb91fabc7a 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -3048,21 +3048,6 @@ static int do_init_module(struct module *mod) */ current->flags &= ~PF_USED_ASYNC; - blocking_notifier_call_chain(&module_notify_list, - MODULE_STATE_COMING, mod); - - /* Set RO and NX regions for core */ - set_section_ro_nx(mod->module_core, - mod->core_text_size, - mod->core_ro_size, - mod->core_size); - - /* Set RO and NX regions for init */ - set_section_ro_nx(mod->module_init, - mod->init_text_size, - mod->init_ro_size, - mod->init_size); - do_mod_ctors(mod); /* Start the module */ if (mod->init != NULL) @@ -3194,9 +3179,26 @@ static int complete_formation(struct module *mod, struct load_info *info) /* This relies on module_mutex for list integrity. */ module_bug_finalize(info->hdr, info->sechdrs, mod); + /* Set RO and NX regions for core */ + set_section_ro_nx(mod->module_core, + mod->core_text_size, + mod->core_ro_size, + mod->core_size); + + /* Set RO and NX regions for init */ + set_section_ro_nx(mod->module_init, + mod->init_text_size, + mod->init_ro_size, + mod->init_size); + /* Mark state as coming so strong_try_module_get() ignores us, * but kallsyms etc. can see us. */ mod->state = MODULE_STATE_COMING; + mutex_unlock(&module_mutex); + + blocking_notifier_call_chain(&module_notify_list, + MODULE_STATE_COMING, mod); + return 0; out: mutex_unlock(&module_mutex); |