diff options
| author | Rob Herring (Arm) <robh@kernel.org> | 2024-07-31 14:14:02 -0600 |
|---|---|---|
| committer | Stephen Boyd <sboyd@kernel.org> | 2024-08-02 16:53:00 -0700 |
| commit | 9d6a53042c49af34603ff32689305a10a5efbb4e (patch) | |
| tree | dd4f1f156fa5a54d4aa777f8009351aec280f2b3 | |
| parent | f9848cfa4bec953603dc9ffb838229e072b0193d (diff) | |
| download | lwn-9d6a53042c49af34603ff32689305a10a5efbb4e.tar.gz lwn-9d6a53042c49af34603ff32689305a10a5efbb4e.zip | |
clk: at91: Use of_property_count_u32_elems() to get property length
Replace of_get_property() with the type specific
of_property_count_u32_elems() to get the property length.
This is part of a larger effort to remove callers of of_get_property()
and similar functions. of_get_property() leaks the DT property data
pointer which is a problem for dynamically allocated nodes which may
be freed.
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Link: https://lore.kernel.org/r/20240731201407.1838385-7-robh@kernel.org
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
| -rw-r--r-- | drivers/clk/at91/dt-compat.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/clk/at91/dt-compat.c b/drivers/clk/at91/dt-compat.c index a32dc2111b90..f5a5f9ba7634 100644 --- a/drivers/clk/at91/dt-compat.c +++ b/drivers/clk/at91/dt-compat.c @@ -563,9 +563,10 @@ of_at91_clk_pll_get_characteristics(struct device_node *np) if (num_cells < 2 || num_cells > 4) return NULL; - if (!of_get_property(np, "atmel,pll-clk-output-ranges", &tmp)) + num_output = of_property_count_u32_elems(np, "atmel,pll-clk-output-ranges"); + if (num_output <= 0) return NULL; - num_output = tmp / (sizeof(u32) * num_cells); + num_output /= num_cells; characteristics = kzalloc(sizeof(*characteristics), GFP_KERNEL); if (!characteristics) |