diff options
| author | Bartosz Golaszewski <bartosz.golaszewski@linaro.org> | 2023-10-04 20:39:06 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2023-10-10 13:12:11 +0100 |
| commit | 9aaa25df9b02bfe5579cbc9b4cc1177c662ec33f (patch) | |
| tree | f1836e5004e2eb9ded21e5a5d074df38704526b3 | |
| parent | 8a6b446d8a13673bfcf44fbd09d737ae4ccf0bfd (diff) | |
| download | lwn-9aaa25df9b02bfe5579cbc9b4cc1177c662ec33f.tar.gz lwn-9aaa25df9b02bfe5579cbc9b4cc1177c662ec33f.zip | |
spi: bcm2835: add a sentinel at the end of the lookup array
GPIOLIB expects the array of lookup entries to be terminated with an
empty member. We need to increase the size of the variable length array
in the lookup table by 1.
Fixes: 21f252cd29f0 ("spi: bcm2835: reduce the abuse of the GPIO API")
Reported-by: Hans de Goede <hdegoede@redhat.com>
Closes: https://lore.kernel.org/lkml/29764d46-8d3d-9794-bbde-d7928a91cbb5@redhat.com/
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20231004183906.97845-1-brgl@bgdev.pl
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | drivers/spi/spi-bcm2835.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/spi/spi-bcm2835.c b/drivers/spi/spi-bcm2835.c index c9078fee3662..e709887eb2a9 100644 --- a/drivers/spi/spi-bcm2835.c +++ b/drivers/spi/spi-bcm2835.c @@ -1299,7 +1299,7 @@ static int bcm2835_spi_setup(struct spi_device *spi) * More on the problem that it addresses: * https://www.spinics.net/lists/linux-gpio/msg36218.html */ - lookup = kzalloc(struct_size(lookup, table, 1), GFP_KERNEL); + lookup = kzalloc(struct_size(lookup, table, 2), GFP_KERNEL); if (!lookup) { ret = -ENOMEM; goto err_cleanup; |