diff options
| author | Armin Wolf <W_Armin@gmx.de> | 2022-11-30 19:41:01 +0100 |
|---|---|---|
| committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2022-12-02 20:29:19 +0100 |
| commit | 98b0cf207b61e17f3ea6d9c17334c8ffc2f44863 (patch) | |
| tree | a52d171c8278569c7fc429f9d5348241783671c0 | |
| parent | b7b275e60bcd5f89771e865a8239325f86d9927d (diff) | |
| download | lwn-98b0cf207b61e17f3ea6d9c17334c8ffc2f44863.tar.gz lwn-98b0cf207b61e17f3ea6d9c17334c8ffc2f44863.zip | |
ACPI: battery: Call power_supply_changed() when adding hooks
If a battery hook is added to a battery, userspace software
is not informed that the available properties of the battery
might have changed. This for example causes upower to react
slowly if a new battery hook is added during runtime.
Fix this by calling power_supply_changed() if a battery hook
was successfully added/removed.
Tested on a Dell Inspiron 3505.
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
| -rw-r--r-- | drivers/acpi/battery.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c index 306513fec1e1..65b4a1da8f55 100644 --- a/drivers/acpi/battery.c +++ b/drivers/acpi/battery.c @@ -696,7 +696,8 @@ static void __battery_hook_unregister(struct acpi_battery_hook *hook, int lock) if (lock) mutex_lock(&hook_mutex); list_for_each_entry(battery, &acpi_battery_list, list) { - hook->remove_battery(battery->bat); + if (!hook->remove_battery(battery->bat)) + power_supply_changed(battery->bat); } list_del(&hook->list); if (lock) @@ -735,6 +736,8 @@ void battery_hook_register(struct acpi_battery_hook *hook) __battery_hook_unregister(hook, 0); goto end; } + + power_supply_changed(battery->bat); } pr_info("new extension: %s\n", hook->name); end: |