diff options
| author | Ionut Nicu <ioan.nicu.ext@nsn.com> | 2013-10-11 14:17:10 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-12-04 11:05:11 -0800 |
| commit | 9770b2810aafbb61bff57c39d3384448f0a7b01b (patch) | |
| tree | 4e6771d25feb0020f1dd025d9e13eeaf2e783d79 | |
| parent | 91831b48272d5cf2759d6d89a2f67cc7ebec72d0 (diff) | |
| download | lwn-9770b2810aafbb61bff57c39d3384448f0a7b01b.tar.gz lwn-9770b2810aafbb61bff57c39d3384448f0a7b01b.zip | |
i2c: mux: gpio: use gpio_set_value_cansleep()
commit 250ad590d6f12d93f4d85be305b0a598d609232e upstream.
Some gpio chips may have get/set operations that
can sleep. gpio_set_value() only works for chips
which do not sleep, for the others we will get a
kernel warning. Using gpio_set_value_cansleep()
will work for both chips that do sleep and those
who don't.
Signed-off-by: Ionut Nicu <ioan.nicu.ext@nsn.com>
Acked-by: Peter Korsgaard <peter.korsgaard@barco.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/i2c/muxes/i2c-mux-gpio.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c index 2297fa7bb1c1..f821facb0768 100644 --- a/drivers/i2c/muxes/i2c-mux-gpio.c +++ b/drivers/i2c/muxes/i2c-mux-gpio.c @@ -30,8 +30,8 @@ static void i2c_mux_gpio_set(const struct gpiomux *mux, unsigned val) int i; for (i = 0; i < mux->data.n_gpios; i++) - gpio_set_value(mux->gpio_base + mux->data.gpios[i], - val & (1 << i)); + gpio_set_value_cansleep(mux->gpio_base + mux->data.gpios[i], + val & (1 << i)); } static int i2c_mux_gpio_select(struct i2c_adapter *adap, void *data, u32 chan) |