diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2022-01-07 10:33:40 +0300 |
|---|---|---|
| committer | Alexandre Belloni <alexandre.belloni@bootlin.com> | 2022-01-16 23:36:09 +0100 |
| commit | 900ed72c8a190e8c0b87cb17abc645b8ec713011 (patch) | |
| tree | 0a6c88b6422d51ae52d491f1c6675f4a122bcaef | |
| parent | 7372971c1be5b7d4fdd8ad237798bdc1d1d54162 (diff) | |
| download | lwn-900ed72c8a190e8c0b87cb17abc645b8ec713011.tar.gz lwn-900ed72c8a190e8c0b87cb17abc645b8ec713011.zip | |
rtc: gamecube: Fix an IS_ERR() vs NULL check
The devm_kzalloc() function returns NULL on error, it doesn't return
error pointers.
Fixes: 86559400b3ef ("rtc: gamecube: Add a RTC driver for the GameCube, Wii and Wii U")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20220107073340.GF22086@kili
| -rw-r--r-- | drivers/rtc/rtc-gamecube.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/rtc/rtc-gamecube.c b/drivers/rtc/rtc-gamecube.c index 98128746171e..f717b36f4738 100644 --- a/drivers/rtc/rtc-gamecube.c +++ b/drivers/rtc/rtc-gamecube.c @@ -319,8 +319,8 @@ static int gamecube_rtc_probe(struct platform_device *pdev) int ret; d = devm_kzalloc(dev, sizeof(struct priv), GFP_KERNEL); - if (IS_ERR(d)) - return PTR_ERR(d); + if (!d) + return -ENOMEM; d->iob = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(d->iob)) |