diff options
| author | Ilya Dryomov <idryomov@gmail.com> | 2015-04-25 15:56:15 +0300 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2015-05-15 09:10:49 +0200 |
| commit | 8ed0623b0a8604c336c51a44259aa5581343ba6f (patch) | |
| tree | 7b59f7b87da57a890546348700b8cd1eeea8debd | |
| parent | 7a90b15c3bb64b4d59badac51d5dda9a735087e3 (diff) | |
| download | lwn-8ed0623b0a8604c336c51a44259aa5581343ba6f.tar.gz lwn-8ed0623b0a8604c336c51a44259aa5581343ba6f.zip | |
rbd: end I/O the entire obj_request on error
commit 082a75dad84d79d1c15ea9e50f31cb4bb4fa7fd6 upstream.
When we end I/O struct request with error, we need to pass
obj_request->length as @nr_bytes so that the entire obj_request worth
of bytes is completed. Otherwise block layer ends up confused and we
trip on
rbd_assert(more ^ (which == img_request->obj_request_count));
in rbd_img_obj_callback() due to more being true no matter what. We
already do it in most cases but we are missing some, in particular
those where we don't even get a chance to submit any obj_requests, due
to an early -ENOMEM for example.
A number of obj_request->xferred assignments seem to be redundant but
I haven't touched any of obj_request->xferred stuff to keep this small
and isolated.
Cc: Alex Elder <elder@linaro.org>
Reported-by: Shawn Edwards <lesser.evil@gmail.com>
Reviewed-by: Sage Weil <sage@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
| -rw-r--r-- | drivers/block/rbd.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c index 2eb4458f4ba8..78bfd5021827 100644 --- a/drivers/block/rbd.c +++ b/drivers/block/rbd.c @@ -2103,6 +2103,11 @@ static bool rbd_img_obj_end_request(struct rbd_obj_request *obj_request) result, xferred); if (!img_request->result) img_request->result = result; + /* + * Need to end I/O on the entire obj_request worth of + * bytes in case of error. + */ + xferred = obj_request->length; } /* Image object requests don't own their page array */ |