diff options
| author | Bjorn Helgaas <bhelgaas@google.com> | 2015-06-19 15:58:24 -0500 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2015-09-30 10:59:52 +0200 |
| commit | 8c9777e56564e7caeb93e6f61f31fadeb5063a56 (patch) | |
| tree | 2c462c7b890dc80bb2d68ce35355312ced04b84b | |
| parent | a1c6aebe73fa86c171b9b14d3402aaf2abc24975 (diff) | |
| download | lwn-8c9777e56564e7caeb93e6f61f31fadeb5063a56.tar.gz lwn-8c9777e56564e7caeb93e6f61f31fadeb5063a56.zip | |
PCI: Fix TI816X class code quirk
commit d1541dc977d376406f4584d8eb055488655c98ec upstream.
In fixup_ti816x_class(), we assigned "class = PCI_CLASS_MULTIMEDIA_VIDEO".
But PCI_CLASS_MULTIMEDIA_VIDEO is only the two-byte base class/sub-class
and needs to be shifted to make space for the low-order interface byte.
Shift PCI_CLASS_MULTIMEDIA_VIDEO to set the correct class code.
Fixes: 63c4408074cb ("PCI: Add quirk for setting valid class for TI816X Endpoint")
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
CC: Hemant Pedanekar <hemantp@ti.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
| -rw-r--r-- | drivers/pci/quirks.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index 877bfbb4e55c..eee40430b0b0 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -2803,12 +2803,15 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x3c28, vtd_mask_spec_errors); static void fixup_ti816x_class(struct pci_dev *dev) { + u32 class = dev->class; + /* TI 816x devices do not have class code set when in PCIe boot mode */ - dev_info(&dev->dev, "Setting PCI class for 816x PCIe device\n"); - dev->class = PCI_CLASS_MULTIMEDIA_VIDEO; + dev->class = PCI_CLASS_MULTIMEDIA_VIDEO << 8; + dev_info(&dev->dev, "PCI class overridden (%#08x -> %#08x)\n", + class, dev->class); } DECLARE_PCI_FIXUP_CLASS_EARLY(PCI_VENDOR_ID_TI, 0xb800, - PCI_CLASS_NOT_DEFINED, 0, fixup_ti816x_class); + PCI_CLASS_NOT_DEFINED, 0, fixup_ti816x_class); /* Some PCIe devices do not work reliably with the claimed maximum * payload size supported. |