diff options
| author | Kent Overstreet <kent.overstreet@gmail.com> | 2019-07-18 17:32:20 -0400 |
|---|---|---|
| committer | Kent Overstreet <kent.overstreet@linux.dev> | 2023-10-22 17:08:24 -0400 |
| commit | 8627f674bc98d6eeb91f885ca1259d29a0e7aa34 (patch) | |
| tree | ed7f10188c675c00ec179943f335f9adb8e1fd82 | |
| parent | a9058a223fd2168d96195df3b918e395be8869e3 (diff) | |
| download | lwn-8627f674bc98d6eeb91f885ca1259d29a0e7aa34.tar.gz lwn-8627f674bc98d6eeb91f885ca1259d29a0e7aa34.zip | |
bcachefs: Don't unlink iters on unsuccessful commit
Where unlink_on_commit is used, on unsuccessfull commit we're likely
retrying the whole update and were going to be using the same iterators
again.
The management of multiple iterators needs to be gone over a fair bit
more at some point...
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
| -rw-r--r-- | fs/bcachefs/btree_update_leaf.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/bcachefs/btree_update_leaf.c b/fs/bcachefs/btree_update_leaf.c index 4461e42f2367..b878f9a9882c 100644 --- a/fs/bcachefs/btree_update_leaf.c +++ b/fs/bcachefs/btree_update_leaf.c @@ -923,8 +923,6 @@ out_noupdates: bch2_trans_unlink_iters(trans, ~trans->iters_touched| trans->iters_unlink_on_commit); trans->iters_touched = 0; - } else { - bch2_trans_unlink_iters(trans, trans->iters_unlink_on_commit); } trans->nr_updates = 0; trans->mem_top = 0; |