diff options
| author | Mikulas Patocka <mpatocka@redhat.com> | 2009-06-22 10:12:10 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2009-07-02 16:40:59 -0700 |
| commit | 85e05eaba5840385843fe61d8db191be84fe3ac6 (patch) | |
| tree | 18e27194fe742ccafd10e06cafc6e543c52eb8c2 | |
| parent | 4869fdea77052c480c54b9e66a927ba036eab29e (diff) | |
| download | lwn-85e05eaba5840385843fe61d8db191be84fe3ac6.tar.gz lwn-85e05eaba5840385843fe61d8db191be84fe3ac6.zip | |
dm mpath: validate hw_handler argument count
commit e094f4f15f5169526c7200b9bde44b900548a81e upstream.
Fix arg count parsing error in hw handlers.
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | drivers/md/dm-mpath.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c index 736f1d97ea2c..774cc49239ff 100644 --- a/drivers/md/dm-mpath.c +++ b/drivers/md/dm-mpath.c @@ -706,6 +706,11 @@ static int parse_hw_handler(struct arg_set *as, struct multipath *m) if (!hw_argc) return 0; + if (hw_argc > as->argc) { + ti->error = "not enough arguments for hardware handler"; + return -EINVAL; + } + m->hw_handler_name = kstrdup(shift(as), GFP_KERNEL); request_module("scsi_dh_%s", m->hw_handler_name); if (scsi_dh_handler_exist(m->hw_handler_name) == 0) { |