diff options
| author | J. Bruce Fields <bfields@redhat.com> | 2012-03-09 17:02:28 -0500 |
|---|---|---|
| committer | J. Bruce Fields <bfields@redhat.com> | 2012-03-09 17:05:01 -0500 |
| commit | 8546ee518c6662ddb3075249fb31d89e5dbfb7d5 (patch) | |
| tree | 0e56f5de9c1ebd807e06a391cb521421625fe392 | |
| parent | 59deeb9e5a2b535b95327c0d29bb3c2c4c3e8234 (diff) | |
| download | lwn-8546ee518c6662ddb3075249fb31d89e5dbfb7d5.tar.gz lwn-8546ee518c6662ddb3075249fb31d89e5dbfb7d5.zip | |
nfsd4: make sure set CB_PATH_DOWN sequence flag set
Make sure this is set whenever there is no callback channel.
If a client does not set up a callback channel at all, then it will get
this flag set from the very start. That's OK, it can just ignore the
flag if it doesn't care. If a client does care, I think it's better to
inform it of the problem as early as possible.
Reported-by: Rick Macklem <rmacklem@uoguelph.ca>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
| -rw-r--r-- | fs/nfsd/nfs4callback.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c index 6f3ebb48b12f..24b6bcf1e945 100644 --- a/fs/nfsd/nfs4callback.c +++ b/fs/nfsd/nfs4callback.c @@ -986,7 +986,7 @@ static void nfsd4_process_cb_update(struct nfsd4_callback *cb) err = setup_callback_client(clp, &conn, ses); if (err) { - warn_no_callback_path(clp, err); + nfsd4_mark_cb_down(clp, err); return; } /* Yay, the callback channel's back! Restart any callbacks: */ |