diff options
| author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2017-07-01 11:21:59 -0300 |
|---|---|---|
| committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2017-07-18 23:14:14 -0300 |
| commit | 8526bafc149ee4d0df5eabca0f440164ec705c99 (patch) | |
| tree | 74092398a1f1c140272b778df9cad9cfd35868dd | |
| parent | 4b4cd50319127b3b606b8aaf3426d8972df1666a (diff) | |
| download | lwn-8526bafc149ee4d0df5eabca0f440164ec705c99.tar.gz lwn-8526bafc149ee4d0df5eabca0f440164ec705c99.zip | |
perf test sdt: Handle realpath() failure
It can return NULL, in which case we should bail out and remove the
directory created with mkdtemp(), which is stored in the "__tempdir"
variable, not in "tempdir".
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Fixes: 8e5dc848356e ("perf test: Add a test case for SDT event")
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
| -rw-r--r-- | tools/perf/tests/sdt.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/tools/perf/tests/sdt.c b/tools/perf/tests/sdt.c index 5abe8cea54e6..d80171526f6f 100644 --- a/tools/perf/tests/sdt.c +++ b/tools/perf/tests/sdt.c @@ -83,6 +83,8 @@ int test__sdt_event(int subtests __maybe_unused) } /* Note that buildid_dir must be an absolute path */ tempdir = realpath(__tempdir, NULL); + if (tempdir == NULL) + goto error_rmdir; /* At first, scan itself */ set_buildid_dir(tempdir); @@ -100,7 +102,7 @@ int test__sdt_event(int subtests __maybe_unused) error_rmdir: /* Cleanup temporary buildid dir */ - rm_rf(tempdir); + rm_rf(__tempdir); error: free(tempdir); free(myself); |