summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorArnd Bergmann <arnd@arndb.de>2015-11-16 22:34:58 +0100
committerArnd Bergmann <arnd@arndb.de>2015-11-19 16:22:43 +0100
commit851df3dc11136fde86ebd78ee7527cb43c7cd349 (patch)
treef32caa3f1a5fd1d074bc613608c9c7e99d6b01e8
parentf9d6fa5d83325fd638e1f911ac9a109c8f2ca56d (diff)
downloadlwn-851df3dc11136fde86ebd78ee7527cb43c7cd349.tar.gz
lwn-851df3dc11136fde86ebd78ee7527cb43c7cd349.zip
scpi: hide get_scpi_ops in module from built-in code
The scpi_clock driver can be built-in when CONFIG_COMPILE_TEST is set even when ARM_SCPI_PROTOCOL is a loadable module, and that results in a link error: drivers/built-in.o: In function `scpi_clocks_probe': (.text+0x14453c): undefined reference to `get_scpi_ops' Using #if IS_REACHABLE() around the get_scpi_ops() declaration makes it build successfully in this case for compile-testing, but the effect is the same as when ARM_SCPI_PROTOCOL is disabled, as the code will not be used. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Acked-by: Punit Agrawal <punit.agrawal@arm.com>
-rw-r--r--include/linux/scpi_protocol.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/scpi_protocol.h b/include/linux/scpi_protocol.h
index 80af3cd35ae4..72ce932c69b2 100644
--- a/include/linux/scpi_protocol.h
+++ b/include/linux/scpi_protocol.h
@@ -71,7 +71,7 @@ struct scpi_ops {
int (*sensor_get_value)(u16, u32 *);
};
-#if IS_ENABLED(CONFIG_ARM_SCPI_PROTOCOL)
+#if IS_REACHABLE(CONFIG_ARM_SCPI_PROTOCOL)
struct scpi_ops *get_scpi_ops(void);
#else
static inline struct scpi_ops *get_scpi_ops(void) { return NULL; }