diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2015-07-29 13:17:06 +0300 |
|---|---|---|
| committer | Sasha Levin <sasha.levin@oracle.com> | 2015-10-27 22:14:38 -0400 |
| commit | 8437a1598f929204f5bd683431f5f8fa4481cbe9 (patch) | |
| tree | 8c9d0f5c38119a3eb633ef9239614bb4a7345036 | |
| parent | 51935aeef6c9b82ee82d37c5dc5d9244a379b5d1 (diff) | |
| download | lwn-8437a1598f929204f5bd683431f5f8fa4481cbe9.tar.gz lwn-8437a1598f929204f5bd683431f5f8fa4481cbe9.zip | |
clk: versatile: off by one in clk_sp810_timerclken_of_get()
[ Upstream commit 3294bee87091be5f179474f6c39d1d87769635e2 ]
The ">" should be ">=" or we end up reading beyond the end of the array.
Fixes: 6e973d2c4385 ('clk: vexpress: Add separate SP810 driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Pawel Moll <pawel.moll@arm.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
| -rw-r--r-- | drivers/clk/versatile/clk-sp810.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/clk/versatile/clk-sp810.c b/drivers/clk/versatile/clk-sp810.c index c6e86a9a2aa3..5122ef25f595 100644 --- a/drivers/clk/versatile/clk-sp810.c +++ b/drivers/clk/versatile/clk-sp810.c @@ -128,8 +128,8 @@ static struct clk *clk_sp810_timerclken_of_get(struct of_phandle_args *clkspec, { struct clk_sp810 *sp810 = data; - if (WARN_ON(clkspec->args_count != 1 || clkspec->args[0] > - ARRAY_SIZE(sp810->timerclken))) + if (WARN_ON(clkspec->args_count != 1 || + clkspec->args[0] >= ARRAY_SIZE(sp810->timerclken))) return NULL; return sp810->timerclken[clkspec->args[0]].clk; |