diff options
| author | Jiasheng Jiang <jiasheng@iscas.ac.cn> | 2022-05-31 17:47:12 +0800 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2022-06-06 12:38:50 +0100 |
| commit | 82fa8f581a954ddeec1602bed9f8b4a09d100e6e (patch) | |
| tree | cb78e6ded9bca4d0dd115e1931ff5ef11e94f843 | |
| parent | 7472eb8d7dd12b6b9b1a4f4527719cc9c7f5965f (diff) | |
| download | lwn-82fa8f581a954ddeec1602bed9f8b4a09d100e6e.tar.gz lwn-82fa8f581a954ddeec1602bed9f8b4a09d100e6e.zip | |
ASoC: codecs: da7210: add check for i2c_add_driver
As i2c_add_driver could return error if fails, it should be
better to check the return value.
However, if the CONFIG_I2C and CONFIG_SPI_MASTER are both true,
the return value of i2c_add_driver will be covered by
spi_register_driver.
Therefore, it is necessary to add check and return error if fails.
Fixes: aa0e25caafb7 ("ASoC: da7210: Add support for spi regmap")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Link: https://lore.kernel.org/r/20220531094712.2376759-1-jiasheng@iscas.ac.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | sound/soc/codecs/da7210.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/sound/soc/codecs/da7210.c b/sound/soc/codecs/da7210.c index 3fa3042e4424..76a21976ccdd 100644 --- a/sound/soc/codecs/da7210.c +++ b/sound/soc/codecs/da7210.c @@ -1335,6 +1335,8 @@ static int __init da7210_modinit(void) int ret = 0; #if IS_ENABLED(CONFIG_I2C) ret = i2c_add_driver(&da7210_i2c_driver); + if (ret) + return ret; #endif #if defined(CONFIG_SPI_MASTER) ret = spi_register_driver(&da7210_spi_driver); |