diff options
| author | NeilBrown <neilb@suse.de> | 2014-05-28 13:39:23 +1000 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2014-07-11 13:33:43 +0100 |
| commit | 8197104d1f38f1826bb66e23eda1d06958129439 (patch) | |
| tree | 7ab34970ffdebe77e89b0791ea605da6366392f6 | |
| parent | 1e2f98c52b3b79761f9969ae6aef9c079192448b (diff) | |
| download | lwn-8197104d1f38f1826bb66e23eda1d06958129439.tar.gz lwn-8197104d1f38f1826bb66e23eda1d06958129439.zip | |
md: always set MD_RECOVERY_INTR when aborting a reshape or other "resync".
commit 3991b31ea072b070081ca3bfa860a077eda67de5 upstream.
If mddev->ro is set, md_to_sync will (correctly) abort.
However in that case MD_RECOVERY_INTR isn't set.
If a RESHAPE had been requested, then ->finish_reshape() will be
called and it will think the reshape was successful even though
nothing happened.
Normally a resync will not be requested if ->ro is set, but if an
array is stopped while a reshape is on-going, then when the array is
started, the reshape will be restarted. If the array is also set
read-only at this point, the reshape will instantly appear to success,
resulting in data corruption.
Consequently, this patch is suitable for any -stable kernel.
Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
| -rw-r--r-- | drivers/md/md.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/md/md.c b/drivers/md/md.c index db4b4a82843a..30a7b526e1ca 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -7035,8 +7035,10 @@ void md_do_sync(struct mddev *mddev) /* just incase thread restarts... */ if (test_bit(MD_RECOVERY_DONE, &mddev->recovery)) return; - if (mddev->ro) /* never try to sync a read-only array */ + if (mddev->ro) {/* never try to sync a read-only array */ + set_bit(MD_RECOVERY_INTR, &mddev->recovery); return; + } if (test_bit(MD_RECOVERY_SYNC, &mddev->recovery)) { if (test_bit(MD_RECOVERY_CHECK, &mddev->recovery)) |