diff options
author | Eric Dumazet <edumazet@google.com> | 2024-04-04 13:07:51 +0000 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2024-04-08 10:59:56 +0100 |
commit | 802e12ff9cbff3bafb0b6f0fe79cff04dce9de16 (patch) | |
tree | 29d19f658e942a58997379d915937b5d6c99400a | |
parent | b2c919c108abda11ebf16c4e31cf687a4db95a6f (diff) | |
download | lwn-802e12ff9cbff3bafb0b6f0fe79cff04dce9de16.tar.gz lwn-802e12ff9cbff3bafb0b6f0fe79cff04dce9de16.zip |
inet: frags: delay fqdir_free_fn()
fqdir_free_fn() is using very expensive rcu_barrier()
When one netns is dismantled, we often call fqdir_exit()
multiple times, typically lauching fqdir_free_fn() twice.
Delaying by one second fqdir_free_fn() helps to reduce
the number of rcu_barrier() calls, and lock contention
on rcu_state.barrier_mutex.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | net/ipv4/inet_fragment.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/ipv4/inet_fragment.c b/net/ipv4/inet_fragment.c index c88c9034d630..faaec92a46ac 100644 --- a/net/ipv4/inet_fragment.c +++ b/net/ipv4/inet_fragment.c @@ -175,7 +175,7 @@ static void fqdir_free_fn(struct work_struct *work) } } -static DECLARE_WORK(fqdir_free_work, fqdir_free_fn); +static DECLARE_DELAYED_WORK(fqdir_free_work, fqdir_free_fn); static void fqdir_work_fn(struct work_struct *work) { @@ -184,7 +184,7 @@ static void fqdir_work_fn(struct work_struct *work) rhashtable_free_and_destroy(&fqdir->rhashtable, inet_frags_free_cb, NULL); if (llist_add(&fqdir->free_list, &fqdir_free_list)) - queue_work(system_wq, &fqdir_free_work); + queue_delayed_work(system_wq, &fqdir_free_work, HZ); } int fqdir_init(struct fqdir **fqdirp, struct inet_frags *f, struct net *net) |