diff options
| author | Christoph Hellwig <hch@lst.de> | 2024-11-04 07:26:30 +0100 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2024-11-11 09:06:45 -0700 |
| commit | 7ecd2cd4fae3e8410c0a6620f3a83dcdbb254f02 (patch) | |
| tree | 619a3dacf2613b18f3e6e163663d9df2c5535bfb | |
| parent | 60dc5ea6bcfd078b71419640d49afa649acf9450 (diff) | |
| download | lwn-7ecd2cd4fae3e8410c0a6620f3a83dcdbb254f02.tar.gz lwn-7ecd2cd4fae3e8410c0a6620f3a83dcdbb254f02.zip | |
block: fix bio_split_rw_at to take zone_write_granularity into account
Otherwise it can create unaligned writes on zoned devices.
Fixes: a805a4fa4fa3 ("block: introduce zone_write_granularity limit")
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Link: https://lore.kernel.org/r/20241104062647.91160-3-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
| -rw-r--r-- | block/blk-merge.c | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/block/blk-merge.c b/block/blk-merge.c index cc320d9aed1a..859875a5ee90 100644 --- a/block/blk-merge.c +++ b/block/blk-merge.c @@ -292,6 +292,14 @@ static bool bvec_split_segs(const struct queue_limits *lim, return len > 0 || bv->bv_len > max_len; } +static unsigned int bio_split_alignment(struct bio *bio, + const struct queue_limits *lim) +{ + if (op_is_write(bio_op(bio)) && lim->zone_write_granularity) + return lim->zone_write_granularity; + return lim->logical_block_size; +} + /** * bio_split_rw_at - check if and where to split a read/write bio * @bio: [in] bio to be split @@ -354,7 +362,7 @@ split: * split size so that each bio is properly block size aligned, even if * we do not use the full hardware limits. */ - bytes = ALIGN_DOWN(bytes, lim->logical_block_size); + bytes = ALIGN_DOWN(bytes, bio_split_alignment(bio, lim)); /* * Bio splitting may cause subtle trouble such as hang when doing sync |