summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAaron Conole <aconole@redhat.com>2024-11-01 16:47:32 -0400
committerJakub Kicinski <kuba@kernel.org>2024-11-05 17:38:25 -0800
commit7d1c2d517f503c63aac3775b51ec96210a6e6ef9 (patch)
treec61899626267785340069cbbc3efef49689b46db
parent2cd02f2fdd8a92e5b6b85ff64eab0fc549b30c07 (diff)
downloadlwn-7d1c2d517f503c63aac3775b51ec96210a6e6ef9.tar.gz
lwn-7d1c2d517f503c63aac3775b51ec96210a6e6ef9.zip
openvswitch: Pass on secpath details for internal port rx.
Clearing the secpath for internal ports will cause packet drops when ipsec offload or early SW ipsec decrypt are used. Systems that rely on these will not be able to actually pass traffic via openvswitch. There is still an open issue for a flow miss packet - this is because we drop the extensions during upcall and there is no facility to restore such data (and it is non-trivial to add such functionality to the upcall interface). That means that when a flow miss occurs, there will still be packet drops. With this patch, when a flow is found then traffic which has an associated xfrm extension will properly flow. Signed-off-by: Aaron Conole <aconole@redhat.com> Acked-by: Eelco Chaudron <echaudro@redhat.com> Link: https://patch.msgid.link/20241101204732.183840-1-aconole@redhat.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
-rw-r--r--net/openvswitch/vport-internal_dev.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/net/openvswitch/vport-internal_dev.c b/net/openvswitch/vport-internal_dev.c
index 5858d65ea1a9..2412d7813d24 100644
--- a/net/openvswitch/vport-internal_dev.c
+++ b/net/openvswitch/vport-internal_dev.c
@@ -195,7 +195,6 @@ static int internal_dev_recv(struct sk_buff *skb)
skb_dst_drop(skb);
nf_reset_ct(skb);
- secpath_reset(skb);
skb->pkt_type = PACKET_HOST;
skb->protocol = eth_type_trans(skb, netdev);