diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2015-05-28 23:09:19 -0400 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2015-06-03 11:33:08 +0200 |
| commit | 7ab65a19e352f341efaa56a4ee4c5ac34dfc29fc (patch) | |
| tree | c47c206265e93b45dbefd2c725fc631092592599 | |
| parent | 1a3b140801f7ad16c40c5f170a0b77b92149c269 (diff) | |
| download | lwn-7ab65a19e352f341efaa56a4ee4c5ac34dfc29fc.tar.gz lwn-7ab65a19e352f341efaa56a4ee4c5ac34dfc29fc.zip | |
d_walk() might skip too much
commit 2159184ea01e4ae7d15f2017e296d4bc82d5aeb0 upstream.
when we find that a child has died while we'd been trying to ascend,
we should go into the first live sibling itself, rather than its sibling.
Off-by-one in question had been introduced in "deal with deadlock in
d_walk()" and the fix needs to be backported to all branches this one
has been backported to.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
| -rw-r--r-- | fs/dcache.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/fs/dcache.c b/fs/dcache.c index eb540b00d027..e619730ade4c 100644 --- a/fs/dcache.c +++ b/fs/dcache.c @@ -1154,13 +1154,13 @@ ascend: /* might go back up the wrong parent if we have had a rename. */ if (need_seqretry(&rename_lock, seq)) goto rename_retry; - next = child->d_child.next; - while (unlikely(child->d_flags & DCACHE_DENTRY_KILLED)) { + /* go into the first sibling still alive */ + do { + next = child->d_child.next; if (next == &this_parent->d_subdirs) goto ascend; child = list_entry(next, struct dentry, d_child); - next = next->next; - } + } while (unlikely(child->d_flags & DCACHE_DENTRY_KILLED)); rcu_read_unlock(); goto resume; } |