diff options
| author | Bob Liu <bob.liu@oracle.com> | 2015-07-22 14:40:09 +0800 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2015-08-25 16:57:08 +0200 |
| commit | 78e034d300ac1c93e8c6ec0e56ffdc7bc8ae4930 (patch) | |
| tree | 2ca803c2dd3a3b036751f08d4bd0780c02eb9ea5 | |
| parent | 5b7ceda1ba18ac596c7e2741b2dd08cb9be48502 (diff) | |
| download | lwn-78e034d300ac1c93e8c6ec0e56ffdc7bc8ae4930.tar.gz lwn-78e034d300ac1c93e8c6ec0e56ffdc7bc8ae4930.zip | |
xen-blkfront: don't add indirect pages to list when !feature_persistent
commit 7b0767502b5db11cb1f0daef2d01f6d71b1192dc upstream.
We should consider info->feature_persistent when adding indirect page to list
info->indirect_pages, else the BUG_ON() in blkif_free() would be triggered.
When we are using persistent grants the indirect_pages list
should always be empty because blkfront has pre-allocated enough
persistent pages to fill all requests on the ring.
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
Signed-off-by: Bob Liu <bob.liu@oracle.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
| -rw-r--r-- | drivers/block/xen-blkfront.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index 3bb5efdcdc8a..7d0eb3f8d629 100644 --- a/drivers/block/xen-blkfront.c +++ b/drivers/block/xen-blkfront.c @@ -1090,8 +1090,10 @@ static void blkif_completion(struct blk_shadow *s, struct blkfront_info *info, * Add the used indirect page back to the list of * available pages for indirect grefs. */ - indirect_page = pfn_to_page(s->indirect_grants[i]->pfn); - list_add(&indirect_page->lru, &info->indirect_pages); + if (!info->feature_persistent) { + indirect_page = pfn_to_page(s->indirect_grants[i]->pfn); + list_add(&indirect_page->lru, &info->indirect_pages); + } s->indirect_grants[i]->gref = GRANT_INVALID_REF; list_add_tail(&s->indirect_grants[i]->node, &info->grants); } |