diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2009-07-21 10:11:39 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-07-22 11:24:28 -0700 |
| commit | 78a9c9c97455d0f8d2d2098b2252eb4bf65be799 (patch) | |
| tree | bfaf6250d11d9c1f00e99905135d82a27ab1edb5 | |
| parent | 7b55a4a3f761db7daba1ac526ef60f64f5c53689 (diff) | |
| download | lwn-78a9c9c97455d0f8d2d2098b2252eb4bf65be799.tar.gz lwn-78a9c9c97455d0f8d2d2098b2252eb4bf65be799.zip | |
register at91_ether using platform_driver_probe
at91ether_probe lives in .init.text, so using platform_driver_register
to register it is wrong because binding a device after the init memory
is discarded (e.g. via sysfs) results in an oops.
As requested by David Brownell platform_driver_probe is used instead of
moving the probe function to .devinit.text as proposed initially.
This saves some memory, but devices registered after the driver is
probed are not bound (probably there are none) and binding via sysfs
isn't possible.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: David Brownell <dbrownell@users.sourceforge.net>
Acked-by: Andrew Victor <linux@maxim.org.za>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/arm/at91_ether.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/arm/at91_ether.c b/drivers/net/arm/at91_ether.c index 2e7419a61191..5041d10bae9d 100644 --- a/drivers/net/arm/at91_ether.c +++ b/drivers/net/arm/at91_ether.c @@ -1228,7 +1228,6 @@ static int at91ether_resume(struct platform_device *pdev) #endif static struct platform_driver at91ether_driver = { - .probe = at91ether_probe, .remove = __devexit_p(at91ether_remove), .suspend = at91ether_suspend, .resume = at91ether_resume, @@ -1240,7 +1239,7 @@ static struct platform_driver at91ether_driver = { static int __init at91ether_init(void) { - return platform_driver_register(&at91ether_driver); + return platform_driver_probe(&at91ether_driver, at91ether_probe); } static void __exit at91ether_exit(void) |