diff options
| author | Luis Henriques (SUSE) <luis.henriques@linux.dev> | 2024-06-18 15:43:12 +0100 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2024-07-08 23:59:37 -0400 |
| commit | 7882b0187bbeb647967a7b5998ce4ad26ef68a9a (patch) | |
| tree | 7a7c66705381e9077e1e22c5129741fb8d569cc3 | |
| parent | 63469662cc45d41705f14b4648481d5d29cf5999 (diff) | |
| download | lwn-7882b0187bbeb647967a7b5998ce4ad26ef68a9a.tar.gz lwn-7882b0187bbeb647967a7b5998ce4ad26ef68a9a.zip | |
ext4: don't track ranges in fast_commit if inode has inlined data
When fast-commit needs to track ranges, it has to handle inodes that have
inlined data in a different way because ext4_fc_write_inode_data(), in the
actual commit path, will attempt to map the required blocks for the range.
However, inodes that have inlined data will have it's data stored in
inode->i_block and, eventually, in the extended attribute space.
Unfortunately, because fast commit doesn't currently support extended
attributes, the solution is to mark this commit as ineligible.
Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1039883
Signed-off-by: Luis Henriques (SUSE) <luis.henriques@linux.dev>
Tested-by: Ben Hutchings <benh@debian.org>
Fixes: 9725958bb75c ("ext4: fast commit may miss tracking unwritten range during ftruncate")
Link: https://patch.msgid.link/20240618144312.17786-1-luis.henriques@linux.dev
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
| -rw-r--r-- | fs/ext4/fast_commit.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c index f53a02bc0c33..3926a05eceee 100644 --- a/fs/ext4/fast_commit.c +++ b/fs/ext4/fast_commit.c @@ -649,6 +649,12 @@ void ext4_fc_track_range(handle_t *handle, struct inode *inode, ext4_lblk_t star if (ext4_test_mount_flag(inode->i_sb, EXT4_MF_FC_INELIGIBLE)) return; + if (ext4_has_inline_data(inode)) { + ext4_fc_mark_ineligible(inode->i_sb, EXT4_FC_REASON_XATTR, + handle); + return; + } + args.start = start; args.end = end; |