diff options
| author | Guixiong Wei <weiguixiong@bytedance.com> | 2024-03-17 23:05:47 +0800 |
|---|---|---|
| committer | Ingo Molnar <mingo@kernel.org> | 2024-03-22 09:48:59 +0100 |
| commit | 76e9762d66373354b45c33b60e9a53ef2a3c5ff2 (patch) | |
| tree | 3ec184647df3d273ca1bc4c0afc2fd63b4c3afab | |
| parent | 8f69cba096b5cfd09be2d06c15d08dbd4a58c9d7 (diff) | |
| download | lwn-76e9762d66373354b45c33b60e9a53ef2a3c5ff2.tar.gz lwn-76e9762d66373354b45c33b60e9a53ef2a3c5ff2.zip | |
x86/boot: Ignore relocations in .notes sections in walk_relocs() too
Commit:
aaa8736370db ("x86, relocs: Ignore relocations in .notes section")
... only started ignoring the .notes sections in print_absolute_relocs(),
but the same logic should also by applied in walk_relocs() to avoid
such relocations.
[ mingo: Fixed various typos in the changelog, removed extra curly braces from the code. ]
Fixes: aaa8736370db ("x86, relocs: Ignore relocations in .notes section")
Fixes: 5ead97c84fa7 ("xen: Core Xen implementation")
Fixes: da1a679cde9b ("Add /sys/kernel/notes")
Signed-off-by: Guixiong Wei <weiguixiong@bytedance.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20240317150547.24910-1-weiguixiong@bytedance.com
| -rw-r--r-- | arch/x86/tools/relocs.c | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/arch/x86/tools/relocs.c b/arch/x86/tools/relocs.c index b029fb81ebee..e7a44a7f617f 100644 --- a/arch/x86/tools/relocs.c +++ b/arch/x86/tools/relocs.c @@ -746,6 +746,15 @@ static void walk_relocs(int (*process)(struct section *sec, Elf_Rel *rel, if (!(sec_applies->shdr.sh_flags & SHF_ALLOC)) { continue; } + + /* + * Do not perform relocations in .notes sections; any + * values there are meant for pre-boot consumption (e.g. + * startup_xen). + */ + if (sec_applies->shdr.sh_type == SHT_NOTE) + continue; + sh_symtab = sec_symtab->symtab; sym_strtab = sec_symtab->link->strtab; for (j = 0; j < sec->shdr.sh_size/sizeof(Elf_Rel); j++) { |